FIX: product suplier tab: last modif date column was wrongly dependant of module barcode #34170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of module barcode
htdocs/product/fournisseurs.php
Outdated
| @@ -959,7 +959,7 @@ function update_price_from_multicurrency() { | |||
| 'pfp.barcode'=>array('label'=>$langs->trans("BarcodeValue"), 'enabled' => isModEnabled('barcode'), 'checked'=>0, 'position'=>16), | |||
| 'pfp.packaging'=>array('label'=>$langs->trans("PackagingForThisProduct"), 'enabled' => getDolGlobalInt('PRODUCT_USE_SUPPLIER_PACKAGING'), 'checked'=>0, 'position'=>17), | |||
| 'pfp.status'=>array('label'=>$langs->trans("Status"), 'enabled' => 1, 'checked'=>0, 'position'=>40), | |||
| 'pfp.tms'=>array('label'=>$langs->trans("DateModification"), 'enabled' => isModEnabled('barcode'), 'checked'=>1, 'position'=>50), | |||
| 'pfp.tms'=>array('label'=>$langs->trans("DateModification"), 'enabled' => '1', 'checked'=>1, 'position'=>50), | |||
There was a problem hiding this comment.
@marc-dll
The parameter enabled is a int and not a string.
There was a problem hiding this comment.
@lvessiller-opendsi Fixed, thank you !
…t of module barcode, part 2
lvessiller-opendsi
approved these changes
May 16, 2025
eldy
pushed a commit
that referenced
this pull request
Jun 4, 2025
* FIX local taxes text in object line view mode (#34103) * FIX: product suplier tab: last modif date column was wrongly dependant of module barcode (#34170) * FIX: product suplier tab: last modif date column was wrongly dependant of module barcode * FIX: product suplier tab: last modif date column was wrongly dependant of module barcode, part 2 * FIX: pgsql: cast string_agg arguments * FIX: pgsql group concat conversion: modify tests as a consequence --------- Co-authored-by: lvessiller-opendsi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: product suplier tab: last modif date column was wrongly dependant of module barcode
In product supplier list, since using column selector (see c6cb179 from v13 !), the
pfp.tmscolumn was only showed if the module barcode is enabled.