FIX: pgsql: cast string_agg arguments #34210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of module barcode (Dolibarr#34170) * FIX: product suplier tab: last modif date column was wrongly dependant of module barcode * FIX: product suplier tab: last modif date column was wrongly dependant of module barcode, part 2
|
I didn't see at first that a phpunit test existed, I modified it accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: pgsql: cast string_agg arguments
When converting MySQL/MariaDB
GROUP_CONCATcalls to PostgreSQLSTRING_AGG, an error occurs because of incorrect argument types (the literal','that is added if noSEPARATORis given in the original call is of typeunknown, for example).STRING_AGGtakes either(TEXT, TEXT)or(BYTEA, BYTEA)arguments (see https://www.postgresql.org/docs/12/functions-aggregate.html), therefore, I propose casting toTEXT.