PERF: remove useless calls to count() in core classes, tpls and modulebuilder template#34376
Closed
marc-dll wants to merge 4 commits intoDolibarr:18.0from
Closed
PERF: remove useless calls to count() in core classes, tpls and modulebuilder template#34376marc-dll wants to merge 4 commits intoDolibarr:18.0from
marc-dll wants to merge 4 commits intoDolibarr:18.0from
Conversation
added 3 commits
June 8, 2025 11:38
… template, part 2
… template, part 3
… template, part 4
Member
|
As this is refactoring, this must be pushed into develop branch. |
eldy
added
the
PR no feature/refacto into freezed/released branch
Member
|
PR could not be merged into develop branch, so i close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PERF: remove useless calls to count() in core classes, tpls and modulebuilder template
Dolibarr is filled with calls to function
count()whose result is simply compared to 0 (to see if the passedarrayis empty or not) or below a certain value. This loses a lot of time because under the hood, time is spent needlessly to really return the number of elements.I searched for any call to count in main core Dolibarr classes, tpls, and in the modulebuilder template, and replaced those calls (mostly using
empty()or replacingforwithforeach) where necessary.