Skip to content

More flexible file loading in monitor/multi_datasets.py #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jul 24, 2024

Description

Some files written by the preprocessor can have multiple variables (e.g., ones that contain a AuxFactory; this is desired by iris and not a bug). Currently, these files cannot be loaded in monitor/multi_datasets.py since it uses iris.load_cube(). This PR aligns this diagnostic with monitor.py and allows multi-variable input.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.12.0 milestone Jul 24, 2024
@schlunma schlunma requested a review from valeriupredoi July 24, 2024 12:22
@schlunma schlunma self-assigned this Jul 24, 2024
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice indeed, cheers, Manu 🍺

@schlunma schlunma merged commit fa8e655 into main Jul 24, 2024
8 checks passed
@schlunma schlunma deleted the more_flexible_monitoring_load branch July 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants