Skip to content

Conversation

@bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Sep 16, 2024

Description

Adding cmorizer for CAMS data


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script


To help with the number of pull requests:

@bettina-gier bettina-gier marked this pull request as ready for review May 20, 2025 09:51
@bettina-gier bettina-gier requested a review from a team as a code owner May 20, 2025 09:51
@lukruh lukruh self-requested a review May 22, 2025 13:14
Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting the license at ads was not trivial for me, maybe we could drop a note with links to create account, setup cdsapirc file and accept licenses:

In doc/sphinx/source/input.rst change line 503 to:

.. [#note5] Downloading this dataset requires an ECMWF account with an [api key](https://cds.climate.copernicus.eu/how-to-api) in `~/.cdsapirc`. The corresponding licenses need to be accepted at [cds](https://cds.climate.copernicus.eu/profile?tab=licences)/[ads](https://ads.atmosphere.copernicus.eu/).

Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. The download once stopped due to rate limits (?) but after rerunning it everything worked fine. To be able to use --start and --end arguments some changes are required.
The resulting data looks fine. I found realistic values, patterns and sasonal cycles for nbp and fgco2. Units are correct and nothing suspicious found inspecting the meta data or fx files.

@lukruh lukruh self-requested a review May 23, 2025 13:18
Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data looks good recipe_check_obs.yml completed. Downloader and formatter are working fine and I'm happy with the documentation. Good to go from my side. I can provide the path to the formatted data if some of the @ESMValGroup/obs-maintainers wants to have a look.

@bettina-gier
Copy link
Contributor Author

Since Bouwe said

Bouwe Andela
Monday at 2:27 PM
I think Lucas is technical enough to count for both science and tech reviewer

can any of the @ESMValGroup/obs-maintainers move the data to the OBS folders and merge this PR?
I reran it on levante and you can find the RAWOBS folder here:
/work/bd0854/b309137/data_ext/RAW/Tier3/CAMS/
and the formatted data here:
/work/bd0854/b309137/esmval/output/data_formatting_20250905_121548/Tier2/CAMS

The remaining codacy errors are the usual "too many arguments" from our cmorizer function and one issue about possible mask referencing before assignment that won't happen in practice.

@hb326
Copy link
Contributor

hb326 commented Sep 5, 2025

/work/bd0854/b309137/esmval/output/data_formatting_20250905_121548/Tier2/CAMS

I copied both, RAWOBS and OBS. Both are now available on Levante.

@bettina-gier bettina-gier merged commit 3ed5f2d into main Sep 5, 2025
7 of 8 checks passed
@bettina-gier bettina-gier deleted the cmorize_CAMS branch September 5, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants