Skip to content

Add CAMS cmorizer #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add CAMS cmorizer #3749

wants to merge 27 commits into from

Conversation

bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Sep 16, 2024

Description

Adding cmorizer for CAMS data


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script


To help with the number of pull requests:

@bettina-gier bettina-gier marked this pull request as ready for review May 20, 2025 09:51
@bettina-gier bettina-gier requested a review from a team as a code owner May 20, 2025 09:51
@lukruh lukruh self-requested a review May 22, 2025 13:14
Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting the license at ads was not trivial for me, maybe we could drop a note with links to create account, setup cdsapirc file and accept licenses:

In doc/sphinx/source/input.rst change line 503 to:

.. [#note5] Downloading this dataset requires an ECMWF account with an [api key](https://cds.climate.copernicus.eu/how-to-api) in `~/.cdsapirc`. The corresponding licenses need to be accepted at [cds](https://cds.climate.copernicus.eu/profile?tab=licences)/[ads](https://ads.atmosphere.copernicus.eu/).

Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. The download once stopped due to rate limits (?) but after rerunning it everything worked fine. To be able to use --start and --end arguments some changes are required.
The resulting data looks fine. I found realistic values, patterns and sasonal cycles for nbp and fgco2. Units are correct and nothing suspicious found inspecting the meta data or fx files.

@lukruh lukruh self-requested a review May 23, 2025 13:18
Copy link
Contributor

@lukruh lukruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data looks good recipe_check_obs.yml completed. Downloader and formatter are working fine and I'm happy with the documentation. Good to go from my side. I can provide the path to the formatted data if some of the @ESMValGroup/obs-maintainers wants to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants