Climate drivers for fire for REF #3975

jlenh · 2025-04-01T09:04:12Z

Description

Climate drivers for fire for the REF (Climate-REF/climate-ref#215).

This diagnostic includes/will include:

burnt area
fire weather control
fuel load/continuity control

The diagnostic relies on the processing of fire drivers through the ConFire model (dedicated branch from the GitHub repository available at https://github.com/douglask3/Bayesian_fire_models/tree/AR7_REF). The ESMValTool diagnostic includes only the relevant part of the evaluation code (see https://github.com/douglask3/Bayesian_fire_models/blob/AR7_REF/fire_model/ConFire.py for now) as the model run is done offline beforehand. The corresponding result files are made available through a Zenodo archive (will be published with DOI 10.5281/zenodo.14917244) which can be retrieved inside the diagnostic. The other option is to provide a local directory which contains the necessary model files.

The ConFire model relies on a variety of observational datasets:

Global Fire Emissions Database version 5 (Yang Chen, Joanne Hall, Dave van Wees, Niels Andela, Stijn Hantson, Louis Giglio, Guido R. van der Werf, Douglas C. Morton, & James T. Randerson. (2023). Global Fire Emissions Database (GFED5) Burned Area (0.1) [Data set]. Zenodo. https://doi.org/10.5281/zenodo.7668424)
MODIS MOD44B (DiMiceli, C., Sohlberg, R., Townshend, J. (2022). MODIS/Terra Vegetation Continuous Fields Yearly L3 Global 250m SIN Grid V061 [Data set]. NASA EOSDIS Land Processes Distributed Active Archive Center. Accessed 2025-04-01 from https://doi.org/10.5067/MODIS/MOD44B.061)
ESA CCI Biomass (Santoro, M.; Cartus, O. (2024): ESA Biomass Climate Change Initiative (Biomass_cci): Global datasets of forest above-ground biomass for the years 2010, 2015, 2016, 2017, 2018, 2019, 2020 and 2021, v5.01. NERC EDS Centre for Environmental Data Analysis, 22 August 2024. doi:10.5285/bf535053562141c6bb7ad831f5998d77. https://dx.doi.org/10.5285/bf535053562141c6bb7ad831f5998d77)
ISIMIP3a GSWP3-W5E5 dataset (temperature, precipitation, relative humidity; Stefan Lange, Matthias Mengel, Simon Treu, Matthias Büchner (2022): ISIMIP3a atmospheric climate input data (v1.0). ISIMIP Repository. https://doi.org/10.48364/ISIMIP.982724)

This PR:

Closes New fire diagnostic for burnt area calculation #3876
Link to documentation: https://esmvaltool--3975.org.readthedocs.build/en/3975/recipes/recipe_ref_fire.html

Before you get started

☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

🛠 This pull request has a descriptive title
🛠 Code is written according to the code quality guidelines
🛠 Documentation is available
🛠 Tests run successfully
🛠 The list of authors is up to date
🛠 Any changed dependencies have been added or removed correctly
🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

🧪 Recipe runs successfully
🧪 Recipe is well documented
🧪 Figure(s) and data look as expected from literature
🛠 Provenance information has been added

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

… ref_fire_diagnostic

jlenh · 2025-06-20T14:48:39Z

For the reviews?

@valeriupredoi technical
@douglask3 scientific

valeriupredoi · 2025-06-20T15:18:07Z

we know @douglask3 very well - Dougie, accept the invite @axel-lauer has sent you today pls, bud 🍺

valeriupredoi

I started the tech review - will head to the pub in a short bit, so I'll finish it on Monday 🍺

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py

valeriupredoi

OK: next stop is fire_diagnostic.py, but I needs lunch

valeriupredoi · 2025-06-24T12:35:27Z

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py

+            if len(parts) == 2:
+                variable_name = parts[0].strip()
+                variable_value = parts[1].strip()
+                if callable(variable_value):


just out of curiosity, what file is that that contains both executable code and strings?

The relevant file is this one esmvaltool/diag_scripts/fire/parameter_files/variables_info-6-frac_points_0.2-nvariables-frac_random_sample0.2-nvars_6-niterations_5000.txt.

The potential executable relates I suppose to this line for example in the variable file used here:

ESMValTool/esmvaltool/diag_scripts/fire/parameter_files/variables_info-_6-frac_points_0.2-nvariables_-frac_random_sample0.2-nvars_6-niterations_5000.txt

Line 7 in e5bb44c

subset_function:: sub_year_months

I am not sure if in the context of the REF we can expect the particular case of callable functions in this file and thus could get rid of that? We would need @douglask3 to the rescue here to clarify that!

Leaving these comments opened still for now before additional information.

valeriupredoi · 2025-06-24T12:37:58Z

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py

+                        SyntaxError,
+                        MemoryError,
+                        RecursionError,
+                    ) as expt:


looks to me you really want to catch any exception here, so perhaps except Exception as expt: is better

btw why is the handling of that file so fragile that you may expect everyone and their dogs exceptions? Maybe a pre-formatting of it could help?

I think I replaced the except Exception as expt: due to Codacy errors but indeed it is unclear what can be expected there in the file.

Reverted back to except Exception as expt in 1b1dfde and 486b424

valeriupredoi · 2025-06-24T12:40:49Z

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py

+    Parameters
+    ----------
+        file_name: str
+            The name of the file containing the variables.


having just seen how fragile the handling of that file may be, could you please add a few words about it here: file type, extension, and a few of its characteristics

Added some things in 1b1dfde and 486b424

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py

valeriupredoi

OK done with the tech review myself - @jlenh please don't be put off by the number of change requests, they are mostly minor - and, if you think they may yield an unrealistic timescale for integration with the REF, pls ignore (for now) anything. A good idea to open an issue with the bits that we may want to address at a later stage, methinks 🍻

esmvaltool/diag_scripts/fire/fire_diagnostic.py

Co-authored-by: Valeriu Predoi <[email protected]>

jlenh · 2025-07-09T09:47:32Z

OK done with the tech review myself - @jlenh please don't be put off by the number of change requests, they are mostly minor - and, if you think they may yield an unrealistic timescale for integration with the REF, pls ignore (for now) anything. A good idea to open an issue with the bits that we may want to address at a later stage, methinks 🍻

I went over the remaining comments for now on the diagnostic Python file. The code being mostly duplicated and adapted from Doug's repository, it might make it hard to maintain the diagnostic working if some changes are incoming from https://github.com/douglask3/Bayesian_fire_models/tree/AR7_REF, but this is the best we can do for now!

Now it's all yours @douglask3 to have a look if I properly transferred your code and if the results look good. You can also answer some remaining opened comments from @valeriupredoi for some clarifications (otherwise I will close them). If there is a need to update the ConFire model files that are shipped as part of ESMValTool, let me know and I will do that. Once they are also on Zenodo and published, we can set that up as the default option.

jlenh added 7 commits March 4, 2025 14:54

Add arviz dependency

79a1264

add author

1000d4b

Add recipe draft

1c98002

Diagnostic code and utils

7d9e547

Add model run files

6010c85

Adding variables and minor changes

2fbeb2a

Adding Zenodo files download and fix model evaluation

3f6183c

jlenh added diagnostic new recipe Use this label if you are adding a new recipe REF Important for the CMIP Rapid Evaluation Framework (REF) labels Apr 1, 2025

jlenh self-assigned this Apr 1, 2025

bouweandela mentioned this pull request Apr 1, 2025

Climate drivers for fire (Fire burnt area, fire weather and fuel continuity) metric Climate-REF/climate-ref#215

Open

jlenh added 18 commits April 9, 2025 15:01

Units and plots fixes

612b69e

Code style cleanup

7dcfc57

Initial documentation commit

be6ae9b

Code cleanup

80db530

Correct single typo

0c1764d

Code cleaning

a2e4578

Small issues

2da9ebb

Solving minor issues, some remain

bf5b342

(final?) style fixes

b0a75ad

Nope

d1b6ae2

Update code from linked git repo

de8c9fe

Updates on outputs

40b537c

Documentation notes

068a265

Update documentation and add figures

d3924f6

Filename string mixup fixed

963f1e4

Add provenance ancestors in saved ConFire output files

005f44c

Merge branch 'main' of https://github.com/ESMValGroup/ESMValTool into…

9e57e14

… ref_fire_diagnostic

Code formatting and doc

ce7fae8

Functions doc

cc59dc1

jlenh marked this pull request as ready for review May 22, 2025 16:44

jlenh added looking for technical reviewer looking for scientific reviewer labels May 22, 2025

jlenh added 4 commits May 26, 2025 16:03

Figures legend update and small code fixes

d92431c

Merge main branch into ref_fire_diagnostic

5b936ea

Add dependency in pyproject.toml

c8ab453

Remove unused functions from utils

a5db080

jlenh requested a review from valeriupredoi June 20, 2025 14:48

valeriupredoi requested changes Jun 20, 2025

View reviewed changes

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py Show resolved Hide resolved

esmvaltool/diag_scripts/fire/diagnostic_run_confire.py Outdated Show resolved Hide resolved

jlenh added this to the v2.13.0 milestone Jun 20, 2025

valeriupredoi requested changes Jun 24, 2025

View reviewed changes

esmvaltool/diag_scripts/fire/fire_diagnostic.py Outdated Show resolved Hide resolved

esmvaltool/diag_scripts/fire/fire_diagnostic.py Outdated Show resolved Hide resolved

jlenh and others added 8 commits June 25, 2025 09:58

Apply suggestions from code review

5ce0515

Co-authored-by: Valeriu Predoi <[email protected]>

Minor fix from review

804112f

Make compute_vpd function lazy again, and clean provenance record

cc4abbb

Replace path handling using Path library

58936b5

Correct da.divide

5288daa

Address (some) review comments

e5bb44c

Address weird filename read function

1b1dfde

Address weird filename read function - file name/extension

486b424

Merge branch 'main' into ref_fire_diagnostic

69883cb

jlenh added in technical review and removed looking for technical reviewer labels Jul 9, 2025

jlenh and others added 3 commits August 7, 2025 15:49

Merge branch 'main' into ref_fire_diagnostic

4f2a36e

Formatting

b26a7a8

Documentation formatting

a20203f

Climate drivers for fire for REF #3975

Are you sure you want to change the base?

Climate drivers for fire for REF #3975

Uh oh!

Conversation

jlenh commented Apr 1, 2025 • edited by bouweandela Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Before you get started

Checklist

Uh oh!

jlenh commented Jun 20, 2025

Uh oh!

valeriupredoi commented Jun 20, 2025

Uh oh!

valeriupredoi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

valeriupredoi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valeriupredoi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jlenh commented Jul 9, 2025

Uh oh!

Uh oh!

jlenh commented Apr 1, 2025 •

edited by bouweandela

Loading