-
Notifications
You must be signed in to change notification settings - Fork 138
Trace gases (CO2, CH4, N2O) surface concentration diagnostic #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlenh
wants to merge
29
commits into
main
Choose a base branch
from
surface_trace_gases_noaa_gml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(finally) ready for review! Anybody available from @ESMValGroup/tech-reviewers and @ESMValGroup/science-reviewers ?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
diagnostic
looking for scientific reviewer
looking for technical reviewer
new recipe
Use this label if you are adding a new recipe
requires new ESMValCore release
A new release of ESMValCore is needed to solve this issue/merge this pull request..
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new diagnostic aims to evaluate surface concentrations of trace gases by comparing model outputs with surface flask measurements made available by NOAA's GML for CO2, CH4, and N2O. A recipe is added for each supported trace gas and relies on the corresponding NOAA GML dataset entry #3847 .
The diagnostic relies on two scripts stored in
esmvaltool/diag_scripts/surface_trace_gases/
:The diagnostic contains four different plotting routines which produce a total of five plots. In the case of zonal plots, the latitude ranges considered are 60N - 90N, 30N - 60N, 30S - 30N, 90S - 30S, and are plotted in a row each. The surface concentrations are extracted at the stations' locations for all the analysis of the zonal quantities.
For each model entry in the recipe, the following plots will be produced:
And all model entries will be integrated in the following plot:
Requires:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: