Added CMORizer for Yang2020 data #4090
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlunma
added
observations
requires new ESMValCore release
jlenh
reviewed
Jun 13, 2025
There was a problem hiding this comment.
Looks good! Change to the wget downloader is quite practical!
- Downloading and formatting are tested and working with the fix for the
irispackage. - Small addition to clarify the time period of the different products used in developing the reanalysis dataset.
- Tests failing due to the variables CMOR tables being missing in current ESMValCore version.
Co-authored-by: Julien Lenhardt <[email protected]>
Co-authored-by: Julien Lenhardt <[email protected]>
Co-authored-by: Julien Lenhardt <[email protected]>
jlenh
approved these changes
Jun 13, 2025
valeriupredoi
approved these changes
Jun 16, 2025
|
On Levante, data is available here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a downloader and formatter for the variables
areacella,dpn2o, andn2ofluxof the Yang2020 data set. Original publication: https://doi.org/10.1073/pnas.1921914117This requires new custom variables, see ESMValGroup/ESMValCore#2751.
Due to a problem with Iris, this also needs a new Iris release (see SciTools/iris#6506).
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script
To help with the number of pull requests: