Update shaka-player to 5.0.6#8772
Open
absidue wants to merge 3 commits intoFreeTubeApp:developmentfrom
Open
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
PR: dependencies
Member
|
Let me daily drive this for a week Update 1: new build - https://github.com/PikachuEXE/FreeTube/actions/runs/22835861506 |
PikachuEXE
previously approved these changes
Mar 13, 2026
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
played 5.0.4 for 5 days seems fine
|
@absidue I released 5.0.6 today! |
src/renderer/components/ft-shaka-video-player/player-components/ScreenshotButton.js
Show resolved
Hide resolved
ChunkyProgrammer
approved these changes
Mar 17, 2026
PikachuEXE
approved these changes
Mar 17, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Mar 17, 2026
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Menu isnt in the corner anymore
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Member
Author
|
@efb4f5ff-1298-471a-8973-3d47447115dc Previously shaka-player hardcoded it into the corner now places the menu relative to the overflow button/cog icon. If you want it positioned differently you need to do that in the shaka-player repo. |
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #6106
Description
This pull request upgrade shaka-player to version 5.0.6. I also switched to the new ES2021 bundle as it includes a lot less polyfills so is about 100kb smaller.
The goal of this pull request is just to do the upgrade, other changes such as switching to shaka-players chapter markers or testing and enabling their new subtitle settings should be done in follow up pull requests, to avoid stretching the scope of this pull request.
References:
Testing
I spent a few hours testing this and going through all the changelogs and upgrade guides, but as this is a major version bump for something that many users consider to be a core part of the application, please include this in your daily driver builds and test this for a bit before approving. I have to say I was expecting to have to change more things, so I am a bit worried that I have missed some things.
Test build: https://github.com/absidue/FreeTube/actions/runs/22826293673
Desktop