Skip to content

Conversation

@mihaic
Copy link
Member

@mihaic mihaic commented Jun 17, 2025

No description provided.

@mihaic mihaic requested a review from Copilot June 17, 2025 23:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces calibration configuration options for the search command, allowing users to enable/disable prefetcher training and select buffer optimization modes.

  • Added a mapping from string keys to VamanaSearchBufferOptimization values.
  • Exposed two new CLI flags: --no_calibrate_prefetchers and --calibrate_search_buffer.
  • Extended search and main to accept and apply the new calibration parameters.
Comments suppressed due to low confidence (3)

src/svsbench/search.py:124

  • [nitpick] The --no_calibrate_prefetchers flag uses negative logic, which can be confusing. Consider renaming it to --calibrate_prefetchers with action='store_false' to keep flag names positive and more intuitive.
    parser.add_argument("--no_calibrate_prefetchers", action="store_true")

src/svsbench/search.py:124

  • This argument is missing a help string. Adding a help= description will clarify its purpose in the CLI.
    parser.add_argument("--no_calibrate_prefetchers", action="store_true")

src/svsbench/search.py:123

  • Add a help= parameter to explain the available buffer-mode options and their effects when calibrating search buffers.
    )

@mihaic mihaic enabled auto-merge (squash) June 17, 2025 23:22
@mihaic mihaic requested review from aguerreb June 17, 2025 23:23
Copy link

@aguerreb aguerreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mihaic mihaic merged commit 9236d1a into IntelLabs:main Sep 17, 2025
2 checks passed
@mihaic mihaic deleted the calibrate-options branch September 17, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants