Skip to content

Conversation

gregory-halverson-jpl
Copy link
Member

@gregory-halverson-jpl gregory-halverson-jpl commented Jul 8, 2025

tensorflow was used for the artification neural network implementation of FLiES before the look-up table implementation was split off into its own package, but tensorflow is not required for the look-up table implementation

@gregory-halverson gregory-halverson requested a review from Copilot July 8, 2025 19:53
Copilot

This comment was marked as outdated.

@gregory-halverson
Copy link
Contributor

Both tensorflow and keras need to be removed from this package to expand compatibility

@gregory-halverson gregory-halverson requested a review from Copilot July 8, 2025 19:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unneeded tensorflow (and related keras) dependency following the split of the LUT implementation into its own package, and bumps the package version while extending CI testing.

  • Remove keras and tensorflow from test imports and project dependencies
  • Bump version from 1.0.2 to 1.0.3 in pyproject.toml and version.txt
  • Expand GitHub Actions Python test matrix to include 3.11–3.13

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_import_dependencies.py Drop keras/tensorflow entries from import tests
pyproject.toml Remove keras/tensorflow deps; bump version
FLiESLUT/version.txt Bump library version to 1.0.3
.github/workflows/ci.yml Add Python 3.11, 3.12, 3.13 to CI matrix
Comments suppressed due to low confidence (2)

pyproject.toml:6

  • Consider updating the project's CHANGELOG.md or release notes to document the removal of the tensorflow dependency and the version bump to 1.0.3.
version = "1.0.3"

.github/workflows/ci.yml:16

  • [nitpick] You might consider aligning the tested Python versions exactly with the supported versions declared in requires-python (>=3.10) and dropping early EOL versions if needed.
        python-version: ["3.10", "3.11", "3.12", "3.13"]

@gregory-halverson gregory-halverson merged commit b41a0c6 into JPL-Evapotranspiration-Algorithms:main Jul 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants