Skip to content

updating day of year calculation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregory-halverson merged 1 commit into from
Aug 14, 2025
Merged

updating day of year calculation #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["setuptools>=60", "setuptools-scm>=8.0", "wheel"]

[project]
name = "sun-angles"
version = "1.5.0"
version = "1.6.0"
description = "calculates solar zenith and azimuth and daylight hours"
readme = "README.md"
authors = [
Expand All @@ -16,7 +16,7 @@ classifiers = [
dependencies = [
"numpy",
"rasters",
"solar-apparent-time>=1.4.0"
"solar-apparent-time>=1.5.3"
]

requires-python = ">=3.10"
Expand Down
6 changes: 4 additions & 2 deletions sun_angles/calculate_daylight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from dateutil import parser
import pandas as pd

from solar_apparent_time import solar_day_of_year_for_longitude
from solar_apparent_time import calculate_solar_day_of_year

from .SHA_deg_from_DOY_lat import SHA_deg_from_DOY_lat
from .daylight_from_SHA import daylight_from_SHA
Expand Down Expand Up @@ -95,8 +95,10 @@ def calculate_daylight(
if lon is None:
raise ValueError("Longitude (lon) must be provided when using time_UTC to infer day_of_year.")

day_of_year = solar_day_of_year_for_longitude(
day_of_year = calculate_solar_day_of_year(
time_UTC=time_UTC,
geometry=geometry,
lat=lat,
lon=lon
)

Expand Down