Fix channel count for RGBx #2493
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGBx is defined as a 4 channel format where the 4th channel is ignored (5.3.1.1)
bashbaug
reviewed
Aug 19, 2025
| case CL_sRGB: | ||
| case CL_sRGBx: return 3; | ||
|
|
||
| case CL_RGBx: |
There was a problem hiding this comment.
I can definitely see places where it is wrong to return "3" vs. "4" for CL_RGBx, but have you checked that there are no places where we will check the fourth "ignored" channel if we return "4" instead of "3"?
I think we should also keep CL_RGBx and CL_sRGBx in sync, so if we do end up moving CL_RGBx, we should move CL_sRGBx also.
|
I'm going to remove "focused review" while the comment above is being addressed - thanks! |
|
Moved sRGBx as well to channel count 4. Review and test did not uncover any places where the 4th channel would be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGBx is defined as a 4 channel format where the 4th channel is ignored (5.3.1.1)