Remove hard dependency on SPIR-V Headers #2521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
reviewed
Sep 12, 2025
There was a problem hiding this comment.
This adds another config we would need to test. Is it really that bad to clone the SPIR-V headers? If so, it might be wise to add at least one CI config that builds without the SPIR-V headers so this doesn't break.
We could also revisit moving the SPIR-V queries test out of test_api and into test_spirv_new, if that would be helpful, see: #2409 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2409 a hard dependency on SPIR-V Headers was added. This change removes the hard dependency on them and adds a TEST_FAIL in test_conformance/api/test_spirv_queries.cpp when the SPIR-V Headers are not provided but the
cl_khr_spirv_queriesextension is available.