-
Notifications
You must be signed in to change notification settings - Fork 122
setting kernel arguments before recording it in command buffer #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aharon-abramson
wants to merge
4
commits into
KhronosGroup:main
Choose a base branch
from
aharon-abramson:issue_1329
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an image for the life cycle in mutable command buffers and specify that there is no need to set all the kernel arguments before recording it.
EwanC
reviewed
Jun 3, 2025
EwanC
reviewed
Jun 17, 2025
@@ -14686,9 +14686,16 @@ A command-buffer is always in one of the following states: | |||
Recording:: Initial state of a command-buffer on creation, where commands can be | |||
recorded to the command-buffer. | |||
|
|||
[[finalized]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need a new CL_COMMAND_BUFFER_STATE_KHR bit for the finalized state. Not sure if this is a change for the base extension or mutable-dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an image for the life cycle in mutable command buffers and specify that there is no need to set all the kernel arguments before recording it.