Skip to content

setting kernel arguments before recording it in command buffer #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aharon-abramson
Copy link
Contributor

Add an image for the life cycle in mutable command buffers and specify that there is no need to set all the kernel arguments before recording it.

Add an image for the life cycle in mutable command buffers and specify that there is no need to set all the kernel arguments before recording it.
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2025

CLA assistant check
All committers have signed the CLA.

@bashbaug bashbaug added the cl_khr_command_buffer Relating to the command-buffer family of extension label Jun 10, 2025
@bashbaug bashbaug requested a review from kpet June 10, 2025 16:39
@bashbaug bashbaug linked an issue Jun 10, 2025 that may be closed by this pull request
@@ -14686,9 +14686,16 @@ A command-buffer is always in one of the following states:
Recording:: Initial state of a command-buffer on creation, where commands can be
recorded to the command-buffer.

[[finalized]]
Copy link
Contributor

@EwanC EwanC Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a new CL_COMMAND_BUFFER_STATE_KHR bit for the finalized state. Not sure if this is a change for the base extension or mutable-dispatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl_khr_command_buffer Relating to the command-buffer family of extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting kernel arguments before recording it in command buffer
4 participants