relax the full profile fp16 tan accuracy requirement to 2.5 ULP #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The embedded profile accuracy requirement is unchanged and remains 3 ULP.
bashbaug
changed the title
|
I further relaxed the fp16 "tan" accuracy requirement to 2.5 ULP, as we discussed. If we decide that we prefer 2.25 ULP instead, we can simply drop the last commit (and re-rename the PR). |
b-sumner
approved these changes
Jul 1, 2025
|
Merging as discussed in the July 1st teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1303
The embedded profile accuracy requirement is unchanged and remains 3 ULP.