Skip to content

Clarify setting work_dim to zero in command-buffer update #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Jun 18, 2025

Progresses Issue #1390 by clarifying that work_dim can be set to zero to signify no change to the kernle command work dimensions. This is the behavior currently expected in the CTS tests.

Note I have a comment in that issue about further changes we may want to make #1390 (comment)

Actions Issue KhronosGroup#1390
by clarifying that `work_dim` can be set to zero to signify
no change to the kernle command work dimensions. This is the
behavior currently expected in the CTS tests.
@EwanC EwanC changed the title Clatify setting work_dim to zero in command-buffer update Clarify setting work_dim to zero in command-buffer update Jun 18, 2025
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches the example code and the current tests.

I'll hold off merging this pending discussion in #1390.

@bashbaug
Copy link
Contributor

bashbaug commented Jul 1, 2025

Merging as discussed in the July 1st teleconference.

@bashbaug bashbaug merged commit 7b5b87b into KhronosGroup:main Jul 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cl_khr_command_buffer_mutable_dispatch] Inconsistency on work_dim in kernel dispatch config
2 participants