Skip to content

Remove require of cl_icd_dispatch to avoid double typedef #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2025
Merged

Remove require of cl_icd_dispatch to avoid double typedef #1458

merged 2 commits into from
Sep 10, 2025

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Sep 10, 2025

Removing from icd.h would break codes that only include this file.

@Kerilk Kerilk requested a review from bashbaug September 10, 2025 16:07
bashbaug
bashbaug approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the best short-term solution to unblock progress.

We can use #1455 to track a longer-term solution.

@Kerilk @bashbaug
Update xml/cl.xml
86b9ba1 
Co-authored-by: Ben Ashbaugh <[email protected]>
@bashbaug bashbaug merged commit d05e2c3 into KhronosGroup:main Sep 10, 2025
2 checks passed
@bashbaug bashbaug mentioned this pull request Sep 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerilk @bashbaug