-
Notifications
You must be signed in to change notification settings - Fork 158
Build ICD Loader using Clang on Windows #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MathiasMagnus
wants to merge
8
commits into
KhronosGroup:main
Choose a base branch
from
StreamHPC:clang-on-win
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
43834ca
Variable hides global instance
MathiasMagnus ade2bee
System types & headers use anon structs
MathiasMagnus 10ffebb
Unicode codepoint in ASCII string (llvm-rc.exe)
MathiasMagnus d7dde20
Unused arguments (omitting arg names is error)
MathiasMagnus 372c5b5
Use SIZE_MAX (C99)
MathiasMagnus b4d0835
DWORD format specifier
MathiasMagnus 96f6209
Port Windows CI to pwsh
MathiasMagnus 2fe7f91
Linux CI update
MathiasMagnus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,15 @@ | |
* Author: Lenny Komow <[email protected]> | ||
*/ | ||
|
||
// System types aren't ISO compliant | ||
#if defined(_MSC_VER) && !defined(__clang__) | ||
#pragma warning( push ) | ||
#pragma warning( disable : 4201 ) | ||
#elif defined(__clang__) | ||
#pragma clang diagnostic push | ||
#pragma clang diagnostic ignored "-Wc11-extensions" | ||
#endif | ||
|
||
typedef struct LoaderEnumAdapters2 { | ||
ULONG adapter_count; | ||
struct { | ||
|
@@ -78,3 +87,9 @@ typedef struct LoaderQueryRegistryInfo { | |
BYTE output_binary[1]; | ||
}; | ||
} LoaderQueryRegistryInfo; | ||
|
||
#if defined(_MSC_VER) && !defined(__clang__) | ||
#pragma warning( pop ) | ||
#elif defined(__clang__) | ||
#pragma clang diagnostic pop | ||
#endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -107,6 +107,9 @@ void adapterFree(WinAdapter *pWinAdapter) | |||||||||||||||||||||||||||||
// for each vendor encountered | ||||||||||||||||||||||||||||||
BOOL CALLBACK khrIcdOsVendorsEnumerate(PINIT_ONCE InitOnce, PVOID Parameter, PVOID *lpContext) | ||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||
(void)InitOnce; | ||||||||||||||||||||||||||||||
(void)Parameter; | ||||||||||||||||||||||||||||||
(void)lpContext; | ||||||||||||||||||||||||||||||
LONG result; | ||||||||||||||||||||||||||||||
BOOL status = FALSE; | ||||||||||||||||||||||||||||||
const char* platformsName = "SOFTWARE\\Khronos\\OpenCL\\Vendors"; | ||||||||||||||||||||||||||||||
|
@@ -267,7 +270,7 @@ void *khrIcdOsLibraryLoad(const char *libraryName) | |||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
if (!hTemp) | ||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||
KHR_ICD_TRACE("Failed to load driver. Windows error code is %d.\n", GetLastError()); | ||||||||||||||||||||||||||||||
KHR_ICD_TRACE("Failed to load driver. Windows error code is %lu.\n", GetLastError()); | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
return (void*)hTemp; | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
|
@@ -279,7 +282,19 @@ void *khrIcdOsLibraryGetFunctionAddress(void *library, const char *functionName) | |||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||
return NULL; | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
#if defined(_MSC_VER) && !defined(__clang__) | ||||||||||||||||||||||||||||||
#pragma warning( push ) | ||||||||||||||||||||||||||||||
#pragma warning( disable : 4152 ) | ||||||||||||||||||||||||||||||
#elif defined(__clang__) | ||||||||||||||||||||||||||||||
#pragma clang diagnostic push | ||||||||||||||||||||||||||||||
#pragma clang diagnostic ignored "-Wpedantic" | ||||||||||||||||||||||||||||||
#endif | ||||||||||||||||||||||||||||||
return GetProcAddress( (HMODULE)library, functionName); | ||||||||||||||||||||||||||||||
#if defined(_MSC_VER) && !defined(__clang__) | ||||||||||||||||||||||||||||||
#pragma warning( pop ) | ||||||||||||||||||||||||||||||
#elif defined(__clang__) | ||||||||||||||||||||||||||||||
#pragma clang diagnostic pop | ||||||||||||||||||||||||||||||
#endif | ||||||||||||||||||||||||||||||
Comment on lines
+285
to
+297
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would try using:
Suggested change
here. It would be consistent with what we do at other place in the code. You may require an additional include. |
||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
// unload a library. | ||||||||||||||||||||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use
%"PRIuDW"
here instead of%lu
.