Make android paths easier to override #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the OpenCL-ICD-Loader checkout in android is using a patch to override the vendor/layer paths staticaly in the source code. This patch aims at dropping that patch in android. It also moves the overload to the build system file (Soong's blueprint for android) instead of having it staticaly inline in the source code. https://android.googlesource.com/platform/external/OpenCL-ICD-Loader/+/refs/heads/main/loader/icd_platform.h
|
cc @Jeremy-Kemp |
Jeremy-Kemp
approved these changes
Aug 18, 2025
bashbaug
approved these changes
Aug 19, 2025
|
Merging as discussed in the August 19th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the OpenCL-ICD-Loader checkout in android is using a patch to override the vendor/layer paths staticaly in the source code.
This patch aims at dropping that patch in android. It also moves the overload to the build system file (Soong's blueprint for android) instead of having it staticaly inline in the source code.
https://android.googlesource.com/platform/external/OpenCL-ICD-Loader/+/refs/heads/main/loader/icd_platform.h