Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/SPIRV/SPIRVUtil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1846,9 +1846,13 @@ std::string decodeSPIRVTypeName(StringRef Name,
// Returns true if type(s) and number of elements (if vector) is valid
bool checkTypeForSPIRVExtendedInstLowering(IntrinsicInst *II, SPIRVModule *BM) {
switch (II->getIntrinsicID()) {
case Intrinsic::acos:
case Intrinsic::asin:
case Intrinsic::atan:
case Intrinsic::ceil:
case Intrinsic::copysign:
case Intrinsic::cos:
case Intrinsic::cosh:
case Intrinsic::exp:
case Intrinsic::exp2:
case Intrinsic::fabs:
Expand All @@ -1868,8 +1872,10 @@ bool checkTypeForSPIRVExtendedInstLowering(IntrinsicInst *II, SPIRVModule *BM) {
case Intrinsic::round:
case Intrinsic::roundeven:
case Intrinsic::sin:
case Intrinsic::sinh:
case Intrinsic::sqrt:
case Intrinsic::tan:
case Intrinsic::tanh:
case Intrinsic::trunc: {
// Although some of the intrinsics above take multiple arguments, it is
// sufficient to check arg 0 because the LLVM Verifier will have checked
Expand Down
18 changes: 18 additions & 0 deletions lib/SPIRV/SPIRVWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3874,12 +3874,20 @@ static SPIRVWord getBuiltinIdForIntrinsic(Intrinsic::ID IID) {
// and assume that the operations have no side effects (FP status flags
// aren't maintained), so the OpenCL builtin behavior should be
// acceptable.
case Intrinsic::acos:
return OpenCLLIB::Acos;
case Intrinsic::asin:
return OpenCLLIB::Asin;
case Intrinsic::atan:
return OpenCLLIB::Atan;
case Intrinsic::ceil:
return OpenCLLIB::Ceil;
case Intrinsic::copysign:
return OpenCLLIB::Copysign;
case Intrinsic::cos:
return OpenCLLIB::Cos;
case Intrinsic::cosh:
return OpenCLLIB::Cosh;
case Intrinsic::exp:
return OpenCLLIB::Exp;
case Intrinsic::exp2:
Expand Down Expand Up @@ -3920,10 +3928,14 @@ static SPIRVWord getBuiltinIdForIntrinsic(Intrinsic::ID IID) {
return OpenCLLIB::Rint;
case Intrinsic::sin:
return OpenCLLIB::Sin;
case Intrinsic::sinh:
return OpenCLLIB::Sinh;
case Intrinsic::sqrt:
return OpenCLLIB::Sqrt;
case Intrinsic::tan:
return OpenCLLIB::Tan;
case Intrinsic::tanh:
return OpenCLLIB::Tanh;
case Intrinsic::trunc:
return OpenCLLIB::Trunc;
default:
Expand Down Expand Up @@ -4056,8 +4068,12 @@ SPIRVValue *LLVMToSPIRVBase::transIntrinsicInst(IntrinsicInst *II,
}

// Unary FP intrinsic
case Intrinsic::acos:
case Intrinsic::asin:
case Intrinsic::atan:
case Intrinsic::ceil:
case Intrinsic::cos:
case Intrinsic::cosh:
case Intrinsic::exp:
case Intrinsic::exp2:
case Intrinsic::fabs:
Expand All @@ -4070,8 +4086,10 @@ SPIRVValue *LLVMToSPIRVBase::transIntrinsicInst(IntrinsicInst *II,
case Intrinsic::round:
case Intrinsic::roundeven:
case Intrinsic::sin:
case Intrinsic::sinh:
case Intrinsic::sqrt:
case Intrinsic::tan:
case Intrinsic::tanh:
case Intrinsic::trunc: {
if (!checkTypeForSPIRVExtendedInstLowering(II, BM))
break;
Expand Down
78 changes: 78 additions & 0 deletions test/llvm-intrinsics/fp-intrinsics.ll
Original file line number Diff line number Diff line change
Expand Up @@ -344,3 +344,81 @@ entry:
}

declare float @llvm.fma.f32(float, float, float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] acos [[x]]
; CHECK: FunctionEnd

define spir_func float @TestAcos(float %x) {
entry:
%t = tail call float @llvm.acos.f32(float %x)
ret float %t
}

declare float @llvm.acos.f32(float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] asin [[x]]
; CHECK: FunctionEnd

define spir_func float @TestAsin(float %x) {
entry:
%t = tail call float @llvm.asin.f32(float %x)
ret float %t
}

declare float @llvm.asin.f32(float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] atan [[x]]
; CHECK: FunctionEnd

define spir_func float @TestAtan(float %x) {
entry:
%t = tail call float @llvm.atan.f32(float %x)
ret float %t
}

declare float @llvm.atan.f32(float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] cosh [[x]]
; CHECK: FunctionEnd

define spir_func float @TestCosh(float %x) {
entry:
%t = tail call float @llvm.cosh.f32(float %x)
ret float %t
}

declare float @llvm.cosh.f32(float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] sinh [[x]]
; CHECK: FunctionEnd

define spir_func float @TestSinh(float %x) {
entry:
%t = tail call float @llvm.sinh.f32(float %x)
ret float %t
}

declare float @llvm.sinh.f32(float)

; CHECK: Function
; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]]
; CHECK: ExtInst [[var1]] {{[0-9]+}} [[extinst_id]] tanh [[x]]
; CHECK: FunctionEnd

define spir_func float @TestTanh(float %x) {
entry:
%t = tail call float @llvm.tanh.f32(float %x)
ret float %t
}

declare float @llvm.tanh.f32(float)
Loading