[KHR] Tests for sycl_khr_max_work_group_queries extension

[Aympab]

The CTS for the khr extension proposal for the device descriptor max_num_work_groups.

There is a PR for an implementation in AdaptiveCpp.

[CLAassistant]

All committers have signed the CLA.

[keryell]

Formatting to be fixed?

[keryell]

Thanks!
A few remarks.

[keryell]

Thanks!

[bader]

Suggested change

	return;
	auto max_work_groups =
	dev.get_info<khr::info::device::max_num_work_groups<DIMENSION>>();
	for (int i = 0; i < DIMENSION; i++) {
	CHECK(max_work_groups[i] >= 1);
	}
	}
	}
	return;
	auto max_work_groups =
	dev.get_info<khr::info::device::max_num_work_groups<DIMENSION>>();
	for (int i = 0; i < DIMENSION; i++) {
	CHECK(max_work_groups[i] >= 1);
	}
	}

One } seems to be redundant.

[bader]

Please, add an option to https://github.com/KhronosGroup/SYCL-CTS/blob/main/CMakeLists.txt and build locally with any implementation that supports it. I suspect there are some syntax errors in the current version.

add_cts_option(SYCL_CTS_ENABLE_MAX_NUM_WORK_GROUPS
    "Enable ..." OFF
    FORCE_ON ${SYCL_CTS_ENABLE_KHR_TESTS})

[Aympab]

Okay done, I fixed a few syntax issues.
I compiled the CTS with acpp from this PR which supports the extension (removing most of the other CTS tests).

[tomdeakin]

one more review required after resolving above comments.

[keryell]

I am confused. Should it be SYCL_CTS_ENABLE_KHR_MAX_NUM_WORK_GROUPS instead?

[tomdeakin]

Looks like a bug vs line 130

[keryell]

Where/how is this macro set?

[Aympab]

This macro is set by the SYCL implementation
It's a requirement when the extension is implemented, the macro should be defined
(See https://github.com/Aympab/SYCL-Docs/blob/khr-max-num-wg/adoc/extensions/sycl_khr_max_num_work_groups.adoc#L15 )

[Aympab]

I've updated the PR following the discussion in KhronosGroup/SYCL-Docs#712

[tomdeakin]

WG approved to merge