OpenCL Interop: Use matching context when constructing queue

[RossBrunton]

make_queue accepts both a native handle and a context. While the spec
doesn't explictly say so, it's my understanding that the "internal"
native handle of the provided context must match the context of the
provided handle.

This fixes the opencl_interop_constructors test, which was incorrectly
trying to construct a sycl::queue from a native handle created from a
different context.

[CLAassistant]

All committers have signed the CLA.

[keryell]

Would it be the same on line 95, 116, 199, 226, 345 like

            sycl::make_kernel<sycl::backend::opencl>(clKernel, ctsContext);

or is it compatible?

[RossBrunton]

Would it be the same on line 95, 116, 199, 226, 345 like

            sycl::make_kernel<sycl::backend::opencl>(clKernel, ctsContext);

or is it compatible?

What file are you looking at with those line numbers? opencl_interop/opencl_interop_constructors.cpp isn't calling make_kernel on those lines.

A quick skim of line 207 of interop_constructors suggests that it should be fine as clKernel is created from ctsContext.

[keryell]

What file are you looking at with those line numbers?

Curious. I cannot find again what I was looking at. 🤔

[RossBrunton]

@keryell So are there any issues with this change? If we discover issues in another file then we can always fix them as another PR.

[keryell]

Thanks for the bug fix!

[RossBrunton]

@bader I don't have merge permissions, could you merge this please?

[keryell]

@RossBrunton I could merge it, but, if there is no emergency, I prefer @bader to do it as the code owner.