[NFC] Split common.h header [1/N]
#1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR outlines functions like `linearize` and `unlinearize` to their own separate header, because they are only used by a few tests. The change is expected to have positive (albeit probably unnoticeable) impact on overall CTS compile-times. The main motivation/background is to refactor CTS in preparation for using modularized `sycl.hpp` (see KhronosGroup/SYCL-Docs#780). As of today all tests use `common.h` and therefore CTS won't benefit much from fine grained headers because everything anyways is included through a single entry point in form of `common.h`.
AlexeySachkov
commented
Apr 17, 2025
|
@AlexeySachkov So, do you plan to move this into |
Apology, I missed your comment. Yeah, if you agree, then let me move into an existing header instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR outlines functions like
linearizeandunlinearizeto their own separate header, because they are only used by a few tests.The change is expected to have positive (albeit probably unnoticeable) impact on overall CTS compile-times.
The main motivation/background is to refactor CTS in preparation for using modularized
sycl.hpp(see KhronosGroup/SYCL-Docs#780). As of today all tests usecommon.hand therefore CTS won't benefit much from fine grained headers because everything anyways is included through a single entry point in form ofcommon.h.