Remove all discard_queue_events tests for deprecated oneapi extension #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension is deprecated Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
|
|
bader
approved these changes
May 14, 2025
Done, thanks. |
|
@bader Can this be merged? These failures are bothering CI people unnecessarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This oneapi extension is now deprecated (intel/llvm#18059) and not intended for sycl-cts tests. Some of these tests now fail since the implementation is a no-op, so that tests that check for expected warnings fail. intel/llvm#18059 has kept core unit testing of basic SYCL functionality when using the no-op discard_events property (https://github.com/intel/llvm/tree/sycl/sycl/test-e2e/DeprecatedFeatures/DiscardEvents), which checks that the property doesn't alter expected behaviour. Since DPC++ is the only compiler using this extension, this should be sufficient and this duplicate CTS testing should be removed.