Add tests for platform::get_devices() #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds testing for more device_type enumerations in platform::get_devices and improves the coverage of the existing tests. This is related to the clarifications in KhronosGroup/SYCL-Docs#861. Fixes KhronosGroup#1123. Signed-off-by: Larsen, Steffen <[email protected]>
tomdeakin
approved these changes
Aug 27, 2025
|
Seems to be ready for merge. |
TApplencourt
reviewed
Sep 9, 2025
TApplencourt
reviewed
Sep 9, 2025
steffenlarsen
commented
Sep 11, 2025
steffenlarsen
commented
Sep 11, 2025
steffenlarsen
commented
Sep 11, 2025
Signed-off-by: Larsen, Steffen <[email protected]>
TApplencourt
approved these changes
Sep 11, 2025
|
Thanks a lot! |
|
WG approved to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds testing for more device_type enumerations in platform::get_devices and improves the coverage of the existing tests.
This is related to the clarifications in
KhronosGroup/SYCL-Docs#861.
Fixes #1123.