Fix loading absolute path libs with LD_LIBRARY_PATH #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 5aa5b08 changed the way libraries are dynamically loaded when `LD_LIBRARY_PATH` is set to only take the filename into account and not the complete path. This seems to be overlooked code meant for testing as the commit is about video testing and not library loading. Revert the file to its previous state to fix loading libraries that are specified with absolute paths. Fixes GitHub issue KhronosGroup#479.
|
|
|
Friendly ping for review |
|
Any chance someone can look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5aa5b08 changed the way libraries are dynamically loaded when
LD_LIBRARY_PATHis set to only take the filename into account and not the complete path. This seems to be overlooked code meant for testing as the commit is about video testing and not library loading.Revert the file to its previous state to fix loading libraries that are specified with absolute paths.
Fixes GitHub issue #479.