Skip to content

Remove splits.io Support #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ main() {
features="$features,auto-splitting"
fi

if [ "$SKIP_NETWORKING" != "skip" ]; then
features="$features,networking"
fi
# FIXME: Comment back in once we have API bindings again.
# if [ "$SKIP_NETWORKING" != "skip" ]; then
# features="$features,networking"
# fi

if [ "$SKIP_SOFTWARE_RENDERING" != "skip" ]; then
features="$features,software-rendering"
Expand Down
4 changes: 0 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ tiny-skia-path = { version = "0.11.1", default-features = false, optional = true
# SVG Rendering
foldhash = { version = "0.1.3", default-features = false, optional = true }

# Networking
splits-io-api = { version = "0.4.0", optional = true }

# Auto Splitting
livesplit-auto-splitting = { path = "crates/livesplit-auto-splitting", version = "0.1.0", optional = true }
arc-swap = { version = "1.7.1", optional = true }
Expand Down Expand Up @@ -185,7 +182,6 @@ wasm-web = [
"wasm-bindgen",
"web-sys",
]
networking = ["std", "splits-io-api"]
auto-splitting = ["std", "livesplit-auto-splitting", "arc-swap", "log"]

[lib]
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ The documentation is available here:
- [LiveSplit One OBS Plugin](https://github.com/LiveSplit/obs-livesplit-one)
- [chronos Terminal Timer](https://github.com/DarkRTA/chronos)
- [annelid](https://github.com/dagit/annelid)
- [splits.io (Parsing)](https://splits.io)

## Build Instructions

Expand Down
8 changes: 3 additions & 5 deletions src/networking/mod.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
//! The networking module provides functionality to communicate with various
//! speedrunning related websites, such as Splits.io to upload and download runs
//! and Speedrun.com to query and submit to the leaderboards of most games. The
//! module is optional and is not compiled in by default.
//! speedrunning related websites, such as Speedrun.com to query and submit to
//! the leaderboards of most games. The module is optional and is not compiled
//! in by default.

#[cfg(feature = "std")]
pub mod server_protocol;
#[cfg(feature = "networking")]
pub mod splits_io;
83 changes: 0 additions & 83 deletions src/networking/splits_io.rs

This file was deleted.

12 changes: 4 additions & 8 deletions src/run/parser/composite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
//! ```

use super::{
face_split, flitter, livesplit, llanfair, llanfair_gered, portal2_live_timer, shit_split,
source_live_timer, speedrun_igt, splits_io, splitterino, splitterz, splitty,
time_split_tracker, urn, wsplit, TimerKind,
TimerKind, face_split, flitter, livesplit, llanfair, llanfair_gered, portal2_live_timer,
shit_split, source_live_timer, speedrun_igt, splitterino, splitterz, splitty,
time_split_tracker, urn, wsplit,
};
use crate::{platform::path::Path, Run};
use crate::{Run, platform::path::Path};
use core::{result::Result as StdResult, str};

/// The Error type for splits files that couldn't be parsed by the Composite
Expand Down Expand Up @@ -135,10 +135,6 @@ pub fn parse<'source>(
return Ok(parsed(run, TimerKind::LlanfairGered));
}

if let Ok((run, timer)) = splits_io::parse(source) {
return Ok(parsed(run, TimerKind::Generic(timer)));
}

// Splitterino, SourceLiveTimer, Flitter, and SpeedRunIGT need to be
// before Urn because of a false positive due to the nature of parsing
// JSON files.
Expand Down
1 change: 0 additions & 1 deletion src/run/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ pub mod portal2_live_timer;
pub mod shit_split;
pub mod source_live_timer;
pub mod speedrun_igt;
pub mod splits_io;
pub mod splitterino;
pub mod splitterz;
pub mod splitty;
Expand Down
Loading
Loading