meson: respect builtin meson default_library option #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcsclite can be built both statically or shared. It has to be built differently to support static usage due to the delegate mechanism. In order to handle this, separate calls are made to static_library() and shared_library(), which sidestep meson's usual handling for selecting the correct requested build variant. Solve this by looking up the builtin option and choosing whether or not to build each library. This means people intending to only ship the shared library, no longer spend time compiling the static one -- nor have to manually delete it after it is installed by `meson install`. Fixes a stray static library appearing on Gentoo (which builds with default_library=shared). Ref: LudovicRousseau#216 Signed-off-by: Eli Schwartz <[email protected]>
|
Thanks |
|
I completed your patch in 3e734d7 |
|
Thanks. That's a really good point about the delegate library and I don't know why I didn't think of it in the first place. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcsclite can be built both statically or shared. It has to be built differently to support static usage due to the delegate mechanism. In order to handle this, separate calls are made to static_library() and shared_library(), which sidestep meson's usual handling for selecting the correct requested build variant.
Solve this by looking up the builtin option and choosing whether or not to build each library. This means people intending to only ship the shared library, no longer spend time compiling the static one -- nor have to manually delete it after it is installed by
meson install.Fixes a stray static library appearing on Gentoo (which builds with default_library=shared).
Ref: #216