Open
Conversation
These are set in SetCompilerOptions.cmake, which also includes CompilerCaching.cmake. I don't think the CMake files in the platform directory need to set this for their `dummy.cpp`s, but I have kept them setting the standard versions.
This extra include directory is no longer needed.
…s.cmake MythFindPackages.cmake is left with code regarding the embedded external libraries and optional MythTV components that mostly don't perform any checks other than is it enabled. The APPLE section is needed before the FireWire check, so I didn't want to move those.
The build failed to link if VDPAU was not also disabled, so make VDPAU depend on X11 since VDPAU always uses X11. Also, make the VAAPI backend support depend on X11 and libdrm being enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up a few remnants left from my prior CMake changes to setting the C++ standard and including mythconfig.h and then fixes building with X11 disabled when VDPAU is present and not explicitly disabled.
The configure dependencies could be done with a longer list, but this minimal change was sufficient.
@linuxdude42 This is what I meant on IRC regarding the CMake files.
Checklist