Skip to content

[WIP] Test reading past empty messages #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public boolean read() {
}
if (bytes.isEmpty()) {
// we read something from the queue but the MR filtered it i.e. did not dispatch
return false;
return true;
}
messageConsumer.consume(tailer.lastReadIndex(), bytes.toString());
bytes.clear();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ private static long getCurrentQueueFileLength(final Path dataDir) throws IOExcep

@Before
public void before() {
assumeFalse(Jvm.isArm());
// assumeFalse(Jvm.isArm());

// Reader opens queues in read-only mode
if (OS.isWindows())
Expand Down Expand Up @@ -296,14 +296,70 @@ public void shouldNotShowIndexForHistoryMessages() {
MessageHistory.writeHistory(dc);
}
}
}

basicReader()
.asMethodReader(SayWhen.class.getName())
.execute();
// basicReader()
// .asMethodReader(SayWhen.class.getName())
// .execute();
//
// assertTrue(capturedOutput.isEmpty());
// }

assertTrue(capturedOutput.isEmpty());
@Test
public void canReadPastEmptyMessageInReverseOrder() {
dataDir = getTmpDir().toPath();
try (final ChronicleQueue queue = SingleChronicleQueueBuilder.binary(dataDir)
.sourceId(1)
.testBlockSize()
.build()) {
final VanillaMethodWriterBuilder<ChronicleMethodReaderTest.All> methodWriterBuilder = queue.methodWriterBuilder(ChronicleMethodReaderTest.All.class);
final ChronicleMethodReaderTest.All events = methodWriterBuilder.build();
final ExcerptAppender appender = queue.createAppender();

for (int i = 0; i < 3; ) {
ChronicleMethodReaderTest.Method1Type m1 = new ChronicleMethodReaderTest.Method1Type();
m1.text = "hello";
m1.value = i;
m1.number = i;
events.method1(m1);

try (DocumentContext dc = appender.writingDocument()) {
MessageHistory.writeHistory(dc);
}

i++;
ChronicleMethodReaderTest.Method2Type m2 = new ChronicleMethodReaderTest.Method2Type();
m2.text = "goodbye";
m2.value = i;
m2.number = i;
events.method2(m2);
i++;
}
}

System.out.println("Done with the queue!");

ChronicleReader methodReaderForQueue = new ChronicleReader()
.withBasePath(dataDir)
.asMethodReader(ChronicleMethodReaderTest.All.class.getName())
.inReverseOrder()
.withMessageSink(capturedOutput::add);

methodReaderForQueue.execute();

assertThat(capturedOutput.size(), is(8));
capturedOutput.poll();
assertThat(capturedOutput.poll(), containsString("goodbye"));
capturedOutput.poll();
assertThat(capturedOutput.poll(), containsString("hello"));
capturedOutput.poll();
assertThat(capturedOutput.poll(), containsString("goodbye"));
capturedOutput.poll();
assertThat(capturedOutput.poll(), containsString("hello"));
capturedOutput.poll();
}


@Test
public void shouldNotIncludeMessageHistoryByDefaultMethodReader() {
basicReader().
Expand Down