fix(plugin-server): applyEventPropertyUpdates returns whether it did …#17825
Merged
bretthoerner merged 1 commit intomasterfrom Oct 6, 2023
Merged
fix(plugin-server): applyEventPropertyUpdates returns whether it did …#17825bretthoerner merged 1 commit intomasterfrom
bretthoerner merged 1 commit intomasterfrom
Conversation
bretthoerner
force-pushed
the
brett/applyEventPropertyUpdates
branch
2 times, most recently
from
5e46475 to
a29ae1d
Compare
Contributor
Author
|
Added a test that fails on master but passes now. |
…an update, rather than needing to use deep-equals
bretthoerner
force-pushed
the
brett/applyEventPropertyUpdates
branch
from
a29ae1d to
151e025
Compare
Contributor
Author
|
And for good measure: epoberezkin/fast-deep-equal#142 |
tiina303
approved these changes
Oct 6, 2023
Contributor
tiina303
left a comment
tiina303
left a comment
There was a problem hiding this comment.
Hopefully we can clean up updatePersonDeprecated soon too to do optimistic updates based on version and retry on failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…an update, rather than needing to use deep-equals
Problem
Our use of
fast-deep-equaltrips up on some types: https://posthog.sentry.io/issues/4524975934/?alert_rule_id=12777331&alert_type=issue¬ification_uuid=b1b2d9cd-208d-437a-9189-0d1106fb732a&project=6423401&referrer=slackIt turns out that event is trying to
$seta field to an object that literally contains atoStringkey. This trips upfast-deep-equal.Changes
The object copy and
fast-deep-equalcomparison wasn't getting us anything that a simple bool doesn't, so just use a bool.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Existing behavior/tests are expected.