Skip to content

Conversation

stellaraccident
Copy link
Collaborator

  • Replaces earlier hard-coded if(WIN32) style logic.
  • Being able to control this at the top level has proven useful for various system bringup tasks.

* Replaces earlier hard-coded `if(WIN32)` style logic.
* Being able to control this at the top level has proven useful for various system bringup tasks.
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am undecided whether this should make its way into our docs somewhere. This does not seem to fit to https://github.com/ROCm/TheRock/blob/main/README.md#optional-configuration-flags (enable vs. include) and I am not sure we really want to document it user facing but there also isn't a good place in docs/development at the moment.

@stellaraccident
Copy link
Collaborator Author

I am undecided whether this should make its way into our docs somewhere. This does not seem to fit to https://github.com/ROCm/TheRock/blob/main/README.md#optional-configuration-flags (enable vs. include) and I am not sure we really want to document it user facing but there also isn't a good place in docs/development at the moment.

I think it is fine as just available in the CMakeLists for people in the know. It is a special purpose knob.

@stellaraccident stellaraccident merged commit 5fdaea5 into main Oct 13, 2025
6 of 7 checks passed
@stellaraccident stellaraccident deleted the flag_include_profiler branch October 13, 2025 23:50
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants