-
Notifications
You must be signed in to change notification settings - Fork 180
[TRITON] Support gfx1201 for triton gemm_a8w8_blockscale #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
big-yellow-duck
wants to merge
24
commits into
ROCm:main
Choose a base branch
from
EmbeddedLLM:support_gfx1201_min
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NAME Amir Balwel [email protected]
Co-authoured-by: Amir Balwel [email protected]
…aiter into support_gfx1201_min
Co-authored-by: Amir Balwel <[email protected]>
…aiter into support_gfx1201_min
Co-authored-by: Jeff Aw <[email protected]> Signed-off-by: Amir Balwel <[email protected]>
Co-authored-by: Jeff Aw <[email protected]> Signed-off-by: Amir Balwel <[email protected]>
Co-authored-by: Amir Balwel <[email protected]>
…aiter into support_gfx1201_min
…aiter into support_gfx1201_min Co-authored-by: Amir Balwel [email protected]
…il.com>" This reverts commit 879c2c5.
Signed-off-by: tjtanaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds preliminary support for gfx1201 to use
gemm_a8w8_blockscalefrom triton which is used in Qwen/Qwen3-0.6B-FP8Moving forward, more triton kernels can be tuned to optimize the performance of gfx1201.
Technical Details
num_warpsandwaves_per_euto find the optimal execution time for a set of operations.Test Plan
test the tuned configs using
aiter/op_tests/triton_tests/gemm/basic/test_gemm_a8w8_blockscale.pyTest Result
126 tests have passed
2 skipped, (where N or K don't meet preshuffle kernel constraints: N must be multiple of 16, K must be multiple of 32)
Submission Checklist