add compile macros to embed hsa .co files #1862
Open
+34
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
1 task
yuguo68
force-pushed
the
asm_dir_macro
branch
from
f9a8190 to
7254c6a
Compare
yuguo68
changed the title
Contributor
Author
|
@valarLip @alugorey, could you help review? this is (1) the patch we make at Meta to embed the .co files in the binary. (2) to pack the .co files with the PyTorch aiter update, see pytorch/pytorch#172592 (comment). |
yuguo68
force-pushed
the
asm_dir_macro
branch
from
7254c6a to
576caec
Compare
yuguo68
force-pushed
the
asm_dir_macro
branch
from
576caec to
c2a586b
Compare
alugorey
reviewed
Jan 21, 2026
Contributor
alugorey
left a comment
alugorey
left a comment
There was a problem hiding this comment.
LGTM but we need someone on the AITER team to review
Collaborator
|
@valarLip @carlushuang @alugorey Please help review and merge soon, needed for OSS PyTorch's aiter update. |
HaiShaw
approved these changes
Jan 22, 2026
Contributor
Author
|
@valarLip could you help review? aiter mha bwd fav3 is integrated with OSS PyTorch, and we would like to embed the .co files so there is no need to for users to set AITER_ASM_DIR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add compile macros AITER_EMBEDDED_HSA_HEADER and AITER_EMBEDDED_HSA_MAP and use them only when the env var AITER_ASM_DIR is not set.
Therefore we can set it at compile time to embed the .co files to the binary.
This is useful for enabling aiter in PyTorch, see pytorch/pytorch#172592 (comment).
Technical Details
Test Plan
Test Result
Submission Checklist