use FAV3_ON and FAV2_ON for mha bwd instead of ONLY_FAV3 #1882
+49
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@valarLip @slippedJim could you help review? would like to include this PR in PyTorch's aiter version update. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this change makes mha_bwd consistent with mha_fwd, also provides the option to disable bwd FAV3 if necessary (e.g., in OSS PyTorch).
also set both FAV3_ON and FAV2_ON to 1 if they are not defined. On trunk if neither is set the mha_fwd kernel would return -1.
also it seems modules libmha_fwd and libmha_bwd are missing -DFAV2_ON=1, and this PR adds it for bwd.
Technical Details
Test Plan
Test Result
Submission Checklist