Skip to content

Conversation

@huizzhan
Copy link
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Comment on lines +27 to +30
from .gated_delta_rule import (
chunk_gated_delta_rule,
fused_recurrent_gated_delta_rule,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
.gated_delta_rule.fused_recurrent_gated_delta_rule imported but unused

Suggested change
from .gated_delta_rule import (
chunk_gated_delta_rule,
fused_recurrent_gated_delta_rule,
)
from .gated_delta_rule import (
chunk_gated_delta_rule,
)


# GDN computation - SGLang line 700-733
if is_target_verify:
core_attn_out = fused_recurrent_gated_delta_rule_update(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F821> reported by reviewdog 🐶
Undefined name fused_recurrent_gated_delta_rule_update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants