fix test_fused_fp8_quant #1891
Open
fix test_fused_fp8_quant #1891
+21
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-bsod
force-pushed
the
ahmed-bsod/test_fused_fp8_quant
branch
from
4e6eda5 to
4975dd7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors test reference functions to use PyTorch kernels instead of aiter non-triton kernels for better portability and maintainability, and adds support for the gfx1250 GPU architecture.
Changes:
- Replaced aiter-specific
rmsnorm2d_fwdandsilu_and_mulfunctions with PyTorch equivalents (torch.nn.functional.siluand a customrmsnormimplementation) - Added gfx1250 architecture support with float8_e4m3fn dtype
- Simplified function signatures by removing unnecessary parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| op_tests/triton_tests/quant/test_fused_fp8_quant.py | Refactored reference functions to use PyTorch kernels; removed aiter imports and simplified test code |
| aiter/utility/dtypes.py | Added gfx1250 architecture with fp8 dtype support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmed-bsod
force-pushed
the
ahmed-bsod/test_fused_fp8_quant
branch
from
4975dd7 to
4c16a9f
Compare
…torch kernels in reference function instead of aiter non-triton kernels
ahmed-bsod
force-pushed
the
ahmed-bsod/test_fused_fp8_quant
branch
from
4c16a9f to
5bff35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
changed test_silu_mul_quant_fuse and test_rsnorm_quant_fuse to use pytorch kernels in reference function instead of aiter non-triton kernels