-
Notifications
You must be signed in to change notification settings - Fork 269
ck: add CK_USE_GFX95 macro #3636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces the CK_USE_GFX950 macro to replace direct checks for __gfx950__ in template configurations. This change addresses a CI failure in MIOpen where GPU architecture-specific macros used in host code were causing compilation issues.
Changes:
- Added
CK_USE_GFX950macro definition in CMakeLists.txt for gfx950 targets - Replaced
__gfx950__checks withCK_USE_GFX950in conv forward and backward data instances - Removed unused
CK_ENABLE_TF32macro definitions from config.h.in
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Adds conditional definition of CK_USE_GFX950 macro for gfx950 GPU targets |
| device_grouped_conv_fwd_xdl_merged_groups_instance.hpp | Updates architecture check from __gfx950__ to CK_USE_GFX950 |
| device_grouped_conv_bwd_data_xdl_instance.hpp | Updates architecture check from __gfx950__ to CK_USE_GFX950 |
| config.h.in | Removes unused CK_ENABLE_TF32 macro definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| >; | ||
|
|
||
| #if defined(__gfx950__) | ||
| #if defined(CK_USE_GFX950) |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macro name CK_USE_GFX950 doesn't match the pattern established in CMakeLists.txt where it's defined as CK_USE_GFX95 (without the trailing '0'). This inconsistency will cause the conditional compilation to fail.
| #if defined(CK_USE_GFX950) | |
| #if defined(CK_USE_GFX95) |
| >; | ||
|
|
||
| #if defined(__gfx950__) | ||
| #if defined(CK_USE_GFX950) |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macro name CK_USE_GFX950 doesn't match the pattern established in CMakeLists.txt where it's defined as CK_USE_GFX95 (without the trailing '0'). This inconsistency will cause the conditional compilation to fail.
| #if defined(CK_USE_GFX950) | |
| #if defined(CK_USE_GFX95) |
Proposed changes
PR #3248 introduced a GPU architecture related template config in conv_bwd_data instances. It lead to MIOpen CI fail because this filed is used as host code in MIOpen which doesn't have
__gfx950__macro.This PR defined a new macro
CK_USE_GFX95to fix this issue. MIOpen will also enable this macro on gfx950 platform.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered