Skip to content

[release/2.9] UT fixes #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dnikolaev-amd wants to merge 6 commits into
base: release/2.9
Choose a base branch
from
Draft

[release/2.9] UT fixes #2913

dnikolaev-amd wants to merge 6 commits into from
+53 −32

Conversation

@dnikolaev-amd
Copy link

@dnikolaev-amd dnikolaev-amd commented Jan 17, 2026 •
edited
Loading

Skipped tests:

  • distributed/_tools/test_sac_ilp.py::TestSACILP::test_sac_ilp_case1 - CUDA focused test

Fixed tests:

  • export/test_export_opinfo.py::TestExportOpInfoCPU::test_fake_export_*_cpu_float32 (414 tests total)
  • inductor/test_aot_inductor.py::AOTInductorTestABICompatibleGpu::test_aoti_debug_printer_sym_inputs_cuda
  • inductor/test_fxir_backend.py::AOTFxirTestCase::test_aoti_fx_linear - PASSED
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive__batch_norm_with_update_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_addr_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_cross_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_linalg_cross_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_log_softmax_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_masked_log_softmax_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive_native_layer_norm_cpu_float16
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU.test_comprehensive__native_batch_norm_legit_cpu_float16
  • inductor/test_unbacked_symints.py::TestUnbackedSymintsCUDA::test_triton_kernel_grid_cuda
  • profiler/test_profiler.py::TestProfiler::test_disable_external_correlation
  • profiler/test_profiler.py::TestProfiler::test_dynamic_toggle
  • profiler/test_profiler.py::TestProfilerCUDA::test_mem_leak
  • test_flop_counter.py::TestFlopCounter:test_scaled_mm
  • test_nn.py::TestNN::test_rnn_check_device
  • test_sparse_csr.py::TestSparseCSRCUDA::test_sampled_addmm_zero_sized_cuda_complex128
  • test_tensorboard.py::TestTensorBoardSummary::test_mesh

FAILED:

  • test_linalg.py::TestLinalgCPU::test_matmul_mv_cpu_float32 - FLAKY
  • profiler/test_profiler.py::TestProfiler::test_profiler_cuda_sync_events
  • inductor/test_benchmark_fusion.py::BenchmarkingTest::test_benchmark_on_non_zero_device

Fixes ROCM-989

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 17, 2026 •
edited
Loading

Jenkins build for 206c95fc0c8082c3c7818da44f62b3686c2573d0 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 206c95f to 7a3f221 Compare January 19, 2026 15:04
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 19, 2026 •
edited
Loading

Jenkins build for 11230eedc7f3cd6f9c33c9d4e749ebeddb2a2b28 commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 19, 2026 •
edited
Loading

Jenkins build for 11230eedc7f3cd6f9c33c9d4e749ebeddb2a2b28 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 20, 2026 •
edited
Loading

Jenkins build for 49f243c563d35b58c8ae98ed6d40321b1fdc2857 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 49f243c to b560377 Compare January 23, 2026 16:00
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 23, 2026 •
edited
Loading

Jenkins build for b56037734c901382419df7dcf7a5788483aca104 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from af9bed8 to b560377 Compare January 23, 2026 19:12
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 23, 2026 •
edited
Loading

Jenkins build for 2ae8e219662329805444071f5ea569c64efe66a6 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

root and others added 6 commits January 23, 2026 23:44
@dnikolaev-amd
[release/2.9] UT fixes
4226eb5
@0xjeffro @dnikolaev-amd
Fix protobuf test comparison by parsing proto instead of raw strings (p…
1fac084 
…ytorch#162644)

The tests were comparing raw exported strings for protobuf comparison, which is not backward/forward compatible with different versions of protobuf.

This PR parses the strings into protobuf and compares the protobufs directly, similar to what we did in assertImageProto.

Our test failed because we used a different version of protobuf, which output 44100.0 instead of 44100, which resulted in an error. However, they are equal, but only different in the exported strings.

Pull Request resolved: pytorch#162644
Approved by: https://github.com/justinchuby, https://github.com/Skylion007
@parsshar-RH @dnikolaev-amd
fix test_type_hints (pytorch#163150)
c475ba5 
Fixes pytorch#163149

### Summary:
Fixes mypy type checking failures in `test_type_hints` by consolidating typing imports and eliminating duplicate/conflicting import patterns that caused mypy to fail resolving type annotations.

### Impact:

- `test_type_hints` works fine now
- module: tests

Pull Request resolved: pytorch#163150
Approved by: https://github.com/Skylion007
@dnikolaev-amd
fix test_torchinductor_opinfo test_comprehensive_*
1e8c7fe
@chinmaydk99 @dnikolaev-amd
Fix sympy_subs to wrap Python primitives in sympy types
4651cdd
@dnikolaev-amd
fix test/inductor/test_benchmark_fusion.py
18349dd
@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 2ae8e21 to 18349dd Compare January 23, 2026 23:46
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 24, 2026 •
edited
Loading

Jenkins build for 18349dd4326ba40ab2e38743de3ab4433fe1baf1 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnikolaev-amd @0xjeffro @parsshar-RH @chinmaydk99