[develop] Fix flatbuffers include order to resolve build issue with latest ROCm #2923
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for 3d54831a1d4183c3ce46b26b64eebc6c0b64faff commit finished as FAILURE |
ethanwee1
force-pushed
the
fix-flatbuffers-include-order
branch
from
3d54831 to
34dea13
Compare
|
Jenkins build for 34dea13feb6b9f6dc6a2eb639d3042572f2b39be commit finished as FAILURE |
ethanwee1
changed the title
jithunnair-amd
requested review from
jataylo,
jeffdaily,
jithunnair-amd and
pruthvistony
as code owners
jithunnair-amd
changed the title
jithunnair-amd
force-pushed
the
develop
branch
7 times, most recently
from
2bd0fb5 to
fe101ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building PyTorch with latest ROCm, the ROCm flatbuffers headers (version 25.9.23) in /opt/rocm/include are found before PyTorch's vendored flatbuffers headers (version 24.12.23). This causes a static_assert failure in mobile_bytecode_generated.h which expects FLATBUFFERS_VERSION_MAJOR == 24.
Fixes build error:
mobile_bytecode_generated.h:11:41: error: static assertion failed: Non-compatible flatbuffers version include static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&