[release/2.9] Fix flatbuffers include order to resolve build issue with latest ROCm #2930
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithunnair-amd
force-pushed
the
vllm_release_2.9
branch
from
2ccb2e2 to
69ee933
Compare
|
Jenkins build for 69ee933fb328d9e1ce7e371de2c42847aa5b91e5 commit finished as FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building PyTorch with latest ROCm, the ROCm flatbuffers headers (version 25.9.23) in /opt/rocm/include are found before PyTorch's vendored flatbuffers headers (version 24.12.23). This causes a static_assert failure in mobile_bytecode_generated.h which expects FLATBUFFERS_VERSION_MAJOR == 24.
Fixes build error:
mobile_bytecode_generated.h:11:41: error: static assertion failed: Non-compatible flatbuffers version include static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&