Skip to content

Conversation

justinrosner
Copy link
Contributor

@justinrosner justinrosner commented Sep 22, 2025

Motivation

This fixes a recursion error that was being hit in parameterSweeps: https://github.com/ROCm/rocMLIR-internal/issues/2003

Additionally, the python formatting pre-commit check was turned on without the python files being updated. This means that we will not be able to get a passing CI for any python changes until all of the python files under /mlir are updated. This PR additionally disables the checks from running for the time being. See docs here for that corresponding change: https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions

Technical Details

This just passes in the proper V4R1 string

Test Plan

  • Nightly CI passes
  • Weekly CI passes

Test Result

  • Nightly CI
  • Weekly CI

Submission Checklist

@justinrosner
Copy link
Contributor Author

Parameter sweeps is now passing with this change: https://ml-ci-internal.amd.com/job/MLIR/job/mlir/job/PR-1995/5/pipeline-overview/?selected-node=275

@justinrosner justinrosner merged commit c9ccbb2 into develop Sep 25, 2025
13 of 15 checks passed
@justinrosner justinrosner deleted the justinr-parameter-sweeps branch September 25, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants