Fix recursion error in parameterSweeps #1995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes a recursion error that was being hit in parameterSweeps: https://github.com/ROCm/rocMLIR-internal/issues/2003
Additionally, the python formatting pre-commit check was turned on without the python files being updated. This means that we will not be able to get a passing CI for any python changes until all of the python files under /mlir are updated. This PR additionally disables the checks from running for the time being. See docs here for that corresponding change: https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions
Technical Details
This just passes in the proper V4R1 string
Test Plan
Test Result
Submission Checklist