[DRAFT] Attention: pipeline outer loop #2017
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a pass to prepare the pipeline for attention.
TODO: wait until #1990 is merged before merging this PR
Note that this includes changes that have been split into the following PRs:
Technical Details
The pass merges rock.stages to have the following:
PostProcessGemm0 includes softmax.
Performance
We get up to 1.5x speed up vs develop and a median speed up of 1.11x.
Test Plan
Tests pass.
Test Result
Submission Checklist