GH-90: Add workflow files for test CI jobs#4
Merged
charleshofer merged 1 commit intomasterfrom May 15, 2025
Merged
Conversation
charleshofer
changed the title
charleshofer
force-pushed
the
gh90-port-rocm-gpu-ci
branch
from
5111ae6 to
88ed06c
Compare
charleshofer
force-pushed
the
gh90-port-rocm-gpu-ci
branch
from
88ed06c to
d4bc4fc
Compare
mrodden
reviewed
May 14, 2025
Contributor
mrodden
left a comment
mrodden
left a comment
There was a problem hiding this comment.
Actually had a question I thought of later.
Comment on lines
+44
to
+48
| - name: Checkout JAX repo | ||
| uses: actions/chekcout@v4 | ||
| with: | ||
| repository: jax-ml/jax | ||
| path: jax |
Contributor
There was a problem hiding this comment.
What version of jax does it checkout? rocm-main?
Collaborator
Author
There was a problem hiding this comment.
Tip of upstream main. We need to hammer out how we handle tests though. It'd be nice if we were just able to submit broken tests (where it's the test case's fault) to upstream if they merge them quickly. And we talked about doing a skip list somewhere, but I haven't actually made a go at implementing that yet. One option is to just put stuff in the skip list until upstream fixes it. We could also rely on rocm-main in rocm/jax, but then we need to keep up with our sync stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow files for building and running nightly tests and tests on PRs
Story: https://github.com/ROCm/jax-internal/issues/90