GH-90: Add script and workflow for updating the XLA commit hash#6
Merged
GH-90: Add script and workflow for updating the XLA commit hash#6
Conversation
charleshofer
changed the title
mrodden
reviewed
May 14, 2025
Contributor
mrodden
left a comment
mrodden
left a comment
There was a problem hiding this comment.
One change request inline
| @@ -0,0 +1,120 @@ | |||
| #!/usr/bin/env python3 | |||
Contributor
There was a problem hiding this comment.
Can we move this to tools/ instead? I was gonna ask you to port this over earlier because I was hoping to use it when bumping XLA and the plugin to version 0.7.0
JehandadKhan
approved these changes
May 15, 2025
mrodden
reviewed
May 15, 2025
| app-id: ${{ vars.ROCM_REPO_MANAGEMENT_API_2_ID }} | ||
| private-key: ${{ secrets.ROCM_REPO_MANAGEMENT_API_2_PRIV_KEY }} | ||
| - name: Run update script | ||
| run: python3 ci/update_xla_hash.py -v --xla-repo ${{ inputs.xla_repo }} --gh-token $GH_TOKEN ${{ inputs.xla_hash }} |
Contributor
There was a problem hiding this comment.
Gotta fix the path here now
Suggested change
| run: python3 ci/update_xla_hash.py -v --xla-repo ${{ inputs.xla_repo }} --gh-token $GH_TOKEN ${{ inputs.xla_hash }} | |
| run: python3 tools/update_xla_hash.py -v --xla-repo ${{ inputs.xla_repo }} --gh-token $GH_TOKEN ${{ inputs.xla_hash }} |
Adds a workflow that lets us update the XLA commit hash on a given branch. This is mostly a port from the script in the old rocm/jax repository: ROCm/jax#330
charleshofer
force-pushed
the
gh90-xla-sync
branch
from
9e91f6f to
5c831ac
Compare
mrodden
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow that lets us update the XLA commit hash on a given branch. This is mostly a port from the script in the old rocm/jax repository: ROCm/jax#330
Story: https://github.com/ROCm/jax-internal/issues/90