Conversation
charleshofer
force-pushed
the
gh90-fix-ci-ymls
branch
3 times, most recently
from
6ace473 to
b11ca6c
Compare
mrodden
reviewed
May 22, 2025
.github/workflows/build-wheels.yml
Outdated
| build-plugin-docker: | ||
| runs-on: mi-250 | ||
| jobs: | ||
| build-plugin-docker: |
Contributor
There was a problem hiding this comment.
The name is build docker but we are only building wheels...?
Probably a legacy thing but was kind of confusing.
Collaborator
Author
There was a problem hiding this comment.
Oh yeah. Probably just left over from a copy-paste. Will fix
charleshofer
force-pushed
the
gh90-fix-ci-ymls
branch
2 times, most recently
from
8e003aa to
9da660a
Compare
charleshofer
force-pushed
the
gh90-fix-ci-ymls
branch
from
9da660a to
57032de
Compare
mrodden
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs in the CI workflow files that weren't caught with
act. After this change, PR and nightly CI build and test should work.Story: https://github.com/ROCm/jax-internal/issues/90