Skip to content

[hipblaslt] Coverage#1953

Open
davidd-amd wants to merge 23 commits intodevelopfrom
users/davidd-amd/coverage
Open

[hipblaslt] Coverage#1953
davidd-amd wants to merge 23 commits intodevelopfrom
users/davidd-amd/coverage

Conversation

@davidd-amd
Copy link
Contributor

@davidd-amd davidd-amd commented Oct 3, 2025

Motivation

Integrates coverage support from old build system in new build system. Previous coverage support required symbolic links that were a symptom of an issue of how header files are organized in the source tree, so header files were moved and include paths updated to eliminate sym links.

Another issue with coverage was that we conditionally added tests to increase lines covered when coverage is enabled. This is not the purpose of coverage builds. Coverage builds should assess lines covered by routine testing so we now (generally) build and run tests the same way for coverage and routine testing. Differences include build type and ifdef'ing out poisoned functions for coverage builds.

There are additional issues with the coverage tests that should be addressed including that the current coverage levels depend on running the samples. Coverage numbers should not depend on running examples or samples and should rely primarily on unit testing which are deficient in hipblaslt.

To ensure that anyone can generate coverage reports, ease of use presets/targets are provided:

  • Configure: cmake --preset coverage -DGPU_TARGETS="<targets>" -B build -S .
  • Build and run: cmake --build build --parallel --target coverage
image

Technical Details

  • Adds custom commands and targets and a preset to support ease of use.
  • Removes sym links to header files and updates include paths in impacted source files.
  • Updates include paths to relevant targets.

Test Plan

Coverage builds not automated so building by hand (result included). Typical build modes tested in pipelines

@davidd-amd davidd-amd force-pushed the users/davidd-amd/coverage branch 2 times, most recently from fa05001 to 280fcae Compare October 13, 2025 17:13
@davidd-amd davidd-amd force-pushed the users/davidd-amd/coverage branch from 280fcae to c01bbf6 Compare October 13, 2025 18:53
@davidd-amd davidd-amd marked this pull request as ready for review October 21, 2025 14:33
@davidd-amd davidd-amd requested review from a team as code owners October 21, 2025 14:33
@davidd-amd davidd-amd force-pushed the users/davidd-amd/coverage branch from a654dd3 to 5c020ea Compare December 9, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant