SWDEV-546177 - hipModuleGetLoadingMode API impl #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anugodavar
pushed a commit
that referenced
this pull request
Aug 20, 2025
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false * SWDEV-539414 - default handler when GPU core file is generated * SWDEV-540576 - Abort if user request a core dump Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3 --------- Co-authored-by: Assiouras, Ioannis <[email protected]> Co-authored-by: agunashe <[email protected]> [ROCm/clr commit: 9c1bff0]
mattwill-amd
pushed a commit
that referenced
this pull request
Aug 20, 2025
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false * SWDEV-539414 - default handler when GPU core file is generated * SWDEV-540576 - Abort if user request a core dump Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3 --------- Co-authored-by: Assiouras, Ioannis <[email protected]> Co-authored-by: agunashe <[email protected]>
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
from
de311e1 to
18240b2
Compare
This was referenced Aug 22, 2025
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
2 times, most recently
from
332693f to
4b3a6e3
Compare
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
3 times, most recently
from
5329cbd to
bdb99d6
Compare
|
@agunashe are you incrementing the HIP_RUNTIME_API_TABLE_STEP_VERSION for this new function for the rocprofiler-sdk ABI code? If not, could you do so? |
1 task
This reverts commit 6274f2f.
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
from
260d043 to
86cf469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API hipModuleGetLoadingMode implementation
Technical Details
API hipModuleGetLoadingMode implementation
Test Plan
rocprofiler and hip tests pass sucessfully
Test Result
NA
Submission Checklist