Start using rbe workers#401
Conversation
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
12 times, most recently
from
f9a5e7a to
769e105
Compare
| if [[ $1 == "asan" ]]; then | ||
| SANITIZER_ARGS+=("--test_env=ASAN_OPTIONS=suppressions=${SCRIPT_DIR}/asan_ignore_list.txt:use_sigaltstack=0") | ||
| SANITIZER_ARGS+=("--test_env=LSAN_OPTIONS=suppressions=${SCRIPT_DIR}/lsan_ignore_list.txt:use_sigaltstack=0") | ||
| SANITIZER_ARGS+=("--test_env=ASAN_OPTIONS=suppressions=build_tools/rocm/asan_ignore_list.txt:use_sigaltstack=0") |
There was a problem hiding this comment.
Why did you change this? We would still need script_dir for the tag filters?
There was a problem hiding this comment.
ignore lists shall be set as a data dependency to a target so to land to rbe worker. Otherwise bazel will not bring them as they are not in the tree. The path is relative to the runfiles directory in the sandbox!
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
3fd9b68 to
538c33e
Compare
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
087c86b to
d0efa67
Compare
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
2 times, most recently
from
eaaf8ee to
ea63caa
Compare
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
ea63caa to
156f558
Compare
… ci_start_using_rbe_workers
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
0fa0ec8 to
7fd7256
Compare
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
4 times, most recently
from
9f4aa47 to
3008a28
Compare
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
3008a28 to
2f2360a
Compare
| ], | ||
| exec_properties = { | ||
| "container-image": "docker://rocm/tensorflow-build:2.19-jammy-python3.9-rocm6.4.0@sha256:7b42dafbe5401fd84cf951a63f16dd44a84c64a6ba2eeb7675fd0919f03b2bdf", | ||
| "container-image": "docker://rocm/tensorflow-build:latest-jammy-python3.10-rocm6.4.0@sha256:9c2fbc861570735fc86dbf39dd3cefef6a13fcf6ae08358271af52f1aebd4248", |
There was a problem hiding this comment.
Can you update sha to rocm 7.0 image?
| "@bazel_tools//tools/cpp:clang", | ||
| ], | ||
| exec_properties = { | ||
| "container-image": "docker://rocm/tensorflow-build:latest-jammy-python3.10-rocm6.4.0@sha256:9c2fbc861570735fc86dbf39dd3cefef6a13fcf6ae08358271af52f1aebd4248", |
| SANITIZER_ARGS+=("--test_env=TSAN_OPTIONS=suppressions=${SCRIPT_DIR}/tsan_ignore_list.txt::history_size=7:ignore_noninstrumented_modules=1") | ||
| SANITIZER_ARGS+=("--config=tsan") | ||
| TAG_FILTERS=$TAG_FILTERS,-notsan | ||
| EXCLUDED_TESTS+=( |
There was a problem hiding this comment.
Can we put all of them in one place? Any special reason for doing += here?
There was a problem hiding this comment.
Yes they are defined above these are additional excluded tests in case of tsan config. Tsan adds delays and also produces warnings solving which is not a scope of this PR.
There was a problem hiding this comment.
Please add a comment excluded for tsan
| --test_filter=-$(IFS=: ; echo "${EXCLUDED_TESTS[*]}") \ | ||
| "${SANITIZER_ARGS[@]}" \ | ||
| "$@" | ||
| "$@" \ |
There was a problem hiding this comment.
Not sure if this works for every option being passed. Better to exchange 125 and 126 lines
There was a problem hiding this comment.
I think it is better this way. The last option wins. Meaning this way we give to CI the opportunity to override whatever is defined in this script, if required.
alekstheod
force-pushed
the
ci_start_using_rbe_workers
branch
from
2a3af07 to
32032d1
Compare
|
LGTM |
3 participants
Start using rbe workers (run tests and build)